#2265 Issue closed: Fishy NETFS 500_make_backup.sh and 400_restore_backup.sh¶
Labels: enhancement, cleanup, minor bug, no-issue-activity
jsmeix opened issue at 2019-10-25 12:47:¶
It seems our current backup/NETFS/default/500_make_backup.sh
and restore/NETFS/default/400_restore_backup.sh
smell somewhat...
There are several issues in 500_make_backup.sh
see in particular
https://github.com/rear/rear/issues/2258#issuecomment-546281119
and
https://github.com/rear/rear/issues/2258#issuecomment-546335320
Furthermore the general code design in
500_make_backup.sh and 400_restore_backup.sh
seem to not match well.
For example on first glance it seems
400_restore_backup.sh has more up-to-date log handling
because of
https://github.com/rear/rear/pull/1803
while
500_make_backup.sh seems to have better pipe error reporting
because of
https://github.com/rear/rear/pull/1914
So it seems 500_make_backup.sh and 400_restore_backup.sh
need to be overhauled, cleaned-up, and enhanced.
jsmeix commented at 2020-03-23 12:05:¶
An additional issue:
Currently ISO_MAX_SIZE does not implement the maximum size of the
ISO.
Instead it implements the size of the chunks when a backup.tar.gz is
split, cf.
https://github.com/rear/rear/issues/2344#issuecomment-602550299
jsmeix commented at 2020-03-25 13:05:¶
This issue is only a minor bug so no real time pressure
so it is something for "ReaR future" - as time permits.
github-actions commented at 2020-06-26 01:39:¶
Stale issue message
[Export of Github issue for rear/rear.]