#2271 PR merged: Update 650_check_iso_recoverable.sh¶

Labels: enhancement, fixed / solved / done, minor bug, external tool

hpannenb opened issue at 2019-11-01 10:24:¶

Pull Request Details:¶

• Type: Bug Fix

• Impact: Low

• Reference to related issue (URL):
  https://github.com/rear/rear/issues/2162

• How was this pull request tested?
  see https://github.com/rear/rear/issues/2162#issuecomment-541343374

• Brief description of the changes in this pull request:
  Removed the (unnecessary) line in the code of 650_check_iso_recoverable.sh which prevents manually setting the NSRSERVER variable in i.e. local.conf

jsmeix commented at 2019-11-04 13:02:¶

@hpannenb
thank you for your continuous improvements
of the NSR related code in ReaR!

@rear/contributors
if there are no objections from other ReaR maintainers
I would like to merge it tomorrow afternoon.

jsmeix commented at 2019-11-04 13:07:¶

@hpannenb
FYI regarding setting a variable to a default/fallback value
unless the user had it already set, you may have a look at
how I try to achieve that in default.conf via

test "$VAR" || VAR="default_value"

for example see
https://github.com/rear/rear/blob/master/usr/share/rear/conf/default.conf#L226

---

[Export of Github issue for rear/rear.]