#2320 PR merged
: create data path for s390 FDR backups if !exists¶
Labels: enhancement
, bug
, cleanup
, fixed / solved / done
mutable-dan opened issue at 2020-01-21 21:36:¶
if the path for $FDRUPSTREAM_DATA_PATH does not exist, then create
it.
This change is FDR specific for s390 and is only in effect if
ZVM_NAMING is "Y"
Relax-and-Recover (ReaR) Pull Request Template¶
Please fill in the following items before submitting a new pull request:
Pull Request Details:¶
-
Type: Bug Fix
-
Impact: Normal
Description:
If the data destination dir does not exist, then create it
jsmeix commented at 2020-01-22 09:47:¶
@mutable-dan
thank you for your continuous testing of ReaR on IBM Z
and for your fixes and adaptions!
mutable-dan commented at 2020-01-24 15:55:¶
You are welcome:
create output dir if !exists
LogPrint... oops. fixed
simplified the constructs as you recommended in this file and two other
paces
added warnings and defaults for env vars not set which answers the
question:
What happens when $opath or $VM_UID is empty?
usr/share/rear/layout/save/FDRUPSTREAM/Linux-s390/990_copy_disklayout_file.sh
usr/share/rear/output/default/950_copy_result_files.sh
usr/share/rear/pack/GNU/Linux/900_create_initramfs.sh
jsmeix commented at 2020-01-27 13:47:¶
@rear/contributors
to be more on the safe side I would appreciate
a second review from another ReaR contributor
mutable-dan commented at 2020-01-27 21:35:¶
good point on the error vs warning. made the change
mutable-dan commented at 2020-01-30 16:44:¶
with the approvals done, I will merge the request.
thank you
jsmeix commented at 2020-02-05 17:24:¶
@mutable-dan
thank you for your continuous testing and your improvements
in particular for external/third-party backup software!
Usually we do not have such software so we depend
on contributions from users of such software.
[Export of Github issue for rear/rear.]