#2342 PR `merged`: Add missing but required NFS users for proper rpcbind startup¶

Labels: enhancement, fixed / solved / done, minor bug

hpannenb opened issue at 2020-03-17 18:44:¶

Type: Bug Fix / New Feature / Enhancement / Other?
Bug Fix
Impact: Low / Normal / High / Critical / Urgent
Low
Reference to related issue (URL):
#2341 and #2250
How was this pull request tested?

Under RHEL7.6: On a HPE DL360 Gen10.
Under Debian 10: -

Brief description of the changes in this pull request:
This pull request adds the missing but required NFS users for RHEL7.x and Debian 10 to let rpcbindstart successfully during recovery.

hpannenb commented at 2020-03-17 18:50:¶

Maybe there is/will be a more sophisticated approach to determine the required users "automagically".
This would be benefitial because i.e. on Ubuntu 18.04.4 I see the rpcbindruns under root which will not lead to such an issue there.

jsmeix commented at 2020-03-18 13:02:¶

Now I found why using ARRAY+=( additional elements )
lets array things work more fail-safe, see
the initial description of @pcahyna in
https://github.com/rear/rear/issues/2220
where he wrote (excerpt):

In the present case, a less invasive change would be
to replace the appending to the array

   CLONE_USERS=( "${CLONE_USERS[@]:-}" daemon rpc usbmuxd usbmux vcsa nobody dbus )

by '+=', i.e.

   CLONE_USERS+=( daemon rpc usbmuxd usbmux vcsa nobody dbus )

(I've verified that '+=' works properly
 even in bash 3 and 'set -ue'.)
This would fix the present case and other cases
where the problem lies in appending to arrays,
but not those where the array is already initialized to ("").

jsmeix commented at 2020-03-19 10:02:¶

@rmetrich
if there are no objectiond from you
I would like to merge it today afternoon.

pcahyna commented at 2020-03-19 11:26:¶

@hpannenb 👍 to the replacement of array operations by +=, even if this is not the main point of the PR. See #2220 , #2223

pcahyna commented at 2020-03-19 11:30:¶

Maybe there is/will be a more sophisticated approach to determine the required users "automagically".
This would be benefitial because i.e. on Ubuntu 18.04.4 I see the rpcbindruns under root which will not lead to such an issue there.

Yes it is a bit unfortunate that we must hard-code such special knowledge.

jsmeix commented at 2020-03-20 10:57:¶

@pcahyna
see https://github.com/rear/rear/issues/2345
for a possible solution that would be simple and generic
without endless mainenance of hard-coded special knowledge.

[Export of Github issue for rear/rear.]

#2342 PR merged: Add missing but required NFS users for proper rpcbind startup¶