#2347 PR merged: Overhauled ISO_MAX_SIZE implementation in 500_make_backup.sh¶

Labels: enhancement, cleanup, fixed / solved / done, minor bug

jsmeix opened issue at 2020-03-23 19:06:¶

• Type: Bug Fix Enhancement

• Impact: Normal

• Reference to related issue (URL):
  https://github.com/rear/rear/issues/2344#issuecomment-602550299
  https://github.com/rear/rear/commit/77773964633e8b6fcfc03841f8fb6770f7c453f7

• How was this pull request tested?
  By me one openSUSE Leap 15.1 using
  various ISO_MAX_SIZE values (100, 200, 400, 600)
  with and without FIRMWARE_FILES=( 'no' )

• Brief description of the changes in this pull request:
  Cleaned up and enhanced the ISO_MAX_SIZE implementation
  in backup/NETFS/default/500_make_backup.sh
  to make it in particular more safe against erroneous settings
  of the ISO_MAX_SIZE variable.

jsmeix commented at 2020-03-23 19:35:¶

With FIRMWARE_FILES=( 'no' ) I get
for ISO_MAX_SIZE=100

Making backup (using backup method NETFS)
ISO_MAX_SIZE should be at least 400 MiB
ERROR: Backup split chunk size -44 less than 100 MiB (ISO_MAX_SIZE too small?)

for ISO_MAX_SIZE=200

Making backup (using backup method NETFS)
ISO_MAX_SIZE should be at least 400 MiB
ERROR: Backup split chunk size 56 less than 100 MiB (ISO_MAX_SIZE too small?)

for ISO_MAX_SIZE=400

Making backup (using backup method NETFS)
Backup gets split in chunks of 256 MiB (ISO_MAX_SIZE 400 minus recovery system size 144)
Creating tar archive '/tmp/rear.7kzFjbOVdN1umE9/tmp/isofs/backup/backup.tar.gz'

With FIRMWARE_FILES=( 'yes' ) I get
for ISO_MAX_SIZE=400

Making backup (using backup method NETFS)
ERROR: Backup split chunk size 56 less than 100 MiB (ISO_MAX_SIZE too small?)

for ISO_MAX_SIZE=600 I get

Making backup (using backup method NETFS)
Backup gets split in chunks of 256 MiB (ISO_MAX_SIZE 600 minus recovery system size 344)
Creating tar archive '/tmp/rear.LpjHY6OtUSMlhZS/tmp/isofs/backup/backup.tar.gz'

jsmeix commented at 2020-03-24 15:20:¶

When there are no objections I would like to merge it tomorrow afternoon.

jsmeix commented at 2020-03-25 13:03:¶

FYI:
Here I kept the current variable naming style (all uppercase) in that script.
The full clean up and overhaul of NETFS 500_make_backup.sh
and 400_restore_backup.sh will happen (as time permits) via
https://github.com/rear/rear/issues/2265

---

[Export of Github issue for rear/rear.]