#2437 PR merged: Add "--type luks1" to the default LUKS_CRYPTSETUP_OPTIONS¶

Labels: enhancement, fixed / solved / done, minor bug

jsmeix opened issue at 2020-06-23 12:56:¶

• Type: Bug Fix Enhancement

• Impact: Normal

• Reference to related issue (URL):
  https://github.com/rear/rear/issues/2432

• How was this pull request tested?
  See https://github.com/rear/rear/issues/2432#issuecomment-648115634

• Brief description of the changes in this pull request:
  Add "--type luks1" to the default LUKS_CRYPTSETUP_OPTIONS

jsmeix commented at 2020-06-24 11:51:¶

When there are no ojbections I would like to merge it tomorrow afternoon.

jsmeix commented at 2020-06-25 13:32:¶

According to
https://github.com/rear/rear/issues/2432#issuecomment-648919800
I will wait for review by @OliverO2 next week.

OliverO2 commented at 2020-06-29 14:06:¶

Test Results on Ubuntu 20.04 LTS¶

• rear mkrescue / rear recover without commit 8504e0d427f9741330401f9e0e5d703ba5c4a5d6

  RESCUE juliet:~ # cryptsetup luksDump /dev/sdb1
  LUKS header information
  Version:        2
  [...]
  

• rear mkrescue / rear recover with commit 8504e0d427f9741330401f9e0e5d703ba5c4a5d6

  RESCUE juliet:~ # cryptsetup luksDump /dev/sdb1
  LUKS header information for /dev/sdb1
  
  Version:        1
  [...]
  

So this patch solves the issue on Ubuntu 20.04 LTS as expected.

---

[Export of Github issue for rear/rear.]