#2448 PR merged: TCG Opal Improvements

Labels: enhancement, fixed / solved / done

OliverO2 opened issue at 2020-06-30 18:17:

Pull Request Details:

  • Type: Enhancement

  • Impact: Normal

  • Reference to related issue (URL): #2436

  • How was this pull request tested? On Ubuntu 20.04 LTS

  • Brief description of the changes in this pull request:

    • OPALPBA, Ubuntu: Fix incomplete file exclusions
      • Fixes omissions reported in #2436.
      • Uses COPY_AS_IS_EXCLUDE where possible.
      • Removes files from the PBA system's staging directory where not copying could not be configured.
    • OPALPBA: Improve boot splash on Ubuntu 20.04
      • Takes into account a change from VT1 to VT7 to hide log messages during the boot process.
      • Improves Plymouth boot splash usage to hide log messages during the reboot after unlocking disks.
    • opaladmin: Add sub-commands 'deactivate', 'reactivate'
      • Makes turning on and off hardware encryption easier on provisioned drives.

jsmeix commented at 2020-07-01 08:21:

@rear/contributors
a second review from another ReaR contributor would be nice to have.
If there is none and if there are no objections I would "just merge" it tomorrow afternoon.

jsmeix commented at 2020-07-01 10:12:

With three approvements I feel sufficiently encouraged
to change my above well elaborated time schedule
and "just merge" it right now :-)

jsmeix commented at 2020-07-01 13:44:

Via https://github.com/rear/rear/commit/daf35e235d0770c663ff8dba866dddec76586a27
I added an explanatory comment in lib/_input-output-functions.sh
that using the ...IfError functions can result unexpected behaviour in certain cases.

OliverO2 commented at 2020-07-01 14:16:

Additional testing has shown that there was some more room for improvements: c58dfb9f7f267917a4b0309a958c614316137840

A comment in the added code explains the underlying issue.

jsmeix commented at 2020-07-02 08:57:

@OliverO2
please tell me when you are finished so that I could merge it.
(This is only FYI - no rush, take your time.)

OliverO2 commented at 2020-07-02 09:08:

@jsmeix
There is nothing else on my list for this iteration. So it’s finished and ready to merge for me.

[Export of Github issue for rear/rear.]