#2453 PR merged: Supply default value for root in grub in UEFI ISO

Labels: bug, fixed / solved / done

pcahyna opened issue at 2020-07-03 15:45:

Pull Request Details:

  • Type: Bug Fix

  • Impact: High

  • Reference to related issue (URL):

Fixes #2434. (problem introduced in PR #2293).

  • How was this pull request tested?

Success was reported by @yontalcar in #2434 (for RHEL 7 and RHEL 8 only though).

  • Brief description of the changes in this pull request:

Sometimes the search command in GRUB2 used in UEFI ISO does not find the root device. This was seen at least in Debian Buster running in Qemu (VirtualBox works fine, RHEL/CentOS in Qemu works fine as well).

To make ReaR work in this case, set $root to a sensible value before trying search. The GRUB2 image created by grub-mkstandalone has $root set to memdisk, which can't work.

This essentially matches how it used to work before PR #2293.

jsmeix commented at 2020-07-03 15:51:

@gozora
I dared to assign it to you because I spotted UEFI soewhere here ;-)
(of course I will also have a look)

jsmeix commented at 2020-07-08 12:26:

https://github.com/rear/rear/pull/2453/commits/77d04392f71a055ff31d1e4e52c4554110d38d48
adds the missing comment, cf. https://github.com/rear/rear/pull/2453#discussion_r449644820

jsmeix commented at 2020-07-08 12:27:

@gozora
feel free to merge it if things look OK for you
(in particular when my comment describes things correctly).

pcahyna commented at 2020-07-09 09:27:

@jsmeix thank you for adding the comment yourself and sorry for my late reaction.

jsmeix commented at 2020-07-09 12:58:

@pcahyna
My pleasure!
Thank you for the fix.

@gozora
Thank you for your continuous help with UEFI issues in ReaR!

[Export of Github issue for rear/rear.]