#2537 PR merged: Completely overhauled USB filesystem kernel module handling

Labels: enhancement, cleanup, fixed / solved / done, minor bug

jsmeix opened issue at 2020-12-09 13:42:

Completely overhauled USB filesystem related kernel module handling:
In prep/USB/default/380_copy_usb_fs_module.sh do no longer unconditionally
add the USB filesystem to the MODULES and MODULES_LOAD arrays
because there are systems where the USB filesystem (e.g. 'ext3')
is no kernel module (e.g. on openSUSE Leap 15.2) and then via
MODULES_LOAD "modprobe ext3" fails with a scaring false alarm

modprobe: FATAL: ... ext3 not found in directory /lib/modules/...

error message from 40-start-udev-or-load-modules.sh that appears
on the user's terminal during recovery system startup.

jsmeix commented at 2020-12-09 14:48:

Tested "rear -D mkbackup" versus "rear -v mkbackup"
and both look as expected.

What appears in the log for "rear -D mkbackup"

+ source /root/rear.github.master/usr/share/rear/prep/USB/default/380_copy_usb_fs_module.sh
++ local usb_fs
+++ fsck -N /dev/disk/by-label/REAR-000
+++ tail -n 1
+++ awk '{print $1}'
+++ cut -d. -f2
++ usb_fs=ext3
++ test ext3
++ test ext3
++ modinfo ext3
modinfo: ERROR: Module ext3 not found.
++ Log 'USB Device /dev/disk/by-label/REAR-000 filesystem ext3 is no kernel module (not found by '\''modinfo ext3'\'')'
++ echo '2020-12-09 14:14:40.328712419 USB Device /dev/disk/by-label/REAR-000 filesystem ext3 is no kernel module (not found by '\''modinfo ext3'\'')'
2020-12-09 14:14:40.328712419 USB Device /dev/disk/by-label/REAR-000 filesystem ext3 is no kernel module (not found by 'modinfo ext3')
+ source_return_code=0

versus what appears in the log for "rear -v mkbackup"

2020-12-09 15:17:01.894428562 Including prep/USB/default/380_copy_usb_fs_module.sh
2020-12-09 15:17:02.015856276 USB Device /dev/disk/by-label/REAR-000 filesystem ext3 is no kernel module (not found by 'modinfo ext3')
2020-12-09 15:17:02.019982957 Including ...

jsmeix commented at 2020-12-09 14:57:

Tested booting the recovery system:
The "Loading modules specified in /etc/modules ..." appears and
there is no longer that

modprobe: FATAL: ... ext3 not found in directory /lib/modules/...

false alarm.
Of course access of the files on the etx3 USB filesystem still works
as it had worked all the time before with the false alarm message.

jsmeix commented at 2020-12-09 15:04:

I would like to merge it tomorrow morning so I can sleep over it
to see if something appears in my mind.

[Export of Github issue for rear/rear.]