#2620 PR merged: Add BACKUP_DUPLICITY_OPTIONS to restore script

Labels: enhancement, fixed / solved / done, minor bug

GreenBlood opened issue at 2021-05-26 10:08:

Additionnal BACKUP_DUPLICITY_OPTIONS options seems to be missing which can cause the recover to fail (options may contain endpoint information for example)

Pull Request Details:

  • Type: Bug Fix

  • Impact: Normal

  • Reference to related issue (URL): https://github.com/rear/rear/issues/2619

  • How was this pull request tested?
    No formal test per-se but I had to make this modification multiple times on my own rear-rescue installations

  • Brief description of the changes in this pull request:
    Adding the $BACKUP_DUPLICITY_OPTIONS variable to duplicity command call when running "rear recover"

gdha commented at 2021-05-27 15:52:

@GreenBlood Well I think I wrote the initial code for DUPLICITY back in 2014 (I guess it was around that time-frame), but it seems most of my code was already overwritten. It was just a proof-of-concept implementation at that time (for fun) and not paying too much attention on useability for others.
I'm actually glad that the ReaR community has mature users on-board who do care about useability and better code ;-)
Thank you.
@jsmeix Also a big thank you for your endless effort in making ReaR a really mature product.
@pcahyna Again the same to you - thank you for bringing it to the crowd (EL ones).

jsmeix commented at 2021-05-28 09:46:

@gdha
thank you for your review and your kind words!

I will merge this pull request today afternoon
(provided no objections from others appear until then).

Afterwards - as time permits - I will try to improve things in particular related to
https://github.com/rear/rear/issues/2619#issuecomment-849617528

jsmeix commented at 2021-05-28 13:17:

@gdha @GreenBlood
I wish you a relaxed and recovering weekend!

[Export of Github issue for rear/rear.]