#2680 Issue closed
: Formatting USB drive for efi is broken¶
Labels: bug
, fixed / solved / done
bearpebble opened issue at 2021-09-27 08:03:¶
Relax-and-Recover (ReaR) Issue Template¶
-
ReaR version ("/usr/sbin/rear -V"):
Relax-and-Recover 2.6 / Git (7c42e2bd3e600d059f24bd0b46526700c1d8bda0)
-
Description of the issue (ideally so that others can reproduce it):
Usingusr/sbin/rear format -v -- --efi /dev/sd...
does not create the layout required for EFI.
The switch--efi
is simply ignored, as it setsFORMAT_EFI=y
, which is never used anywhere else in the code.
https://github.com/rear/rear/blob/7c42e2bd3e600d059f24bd0b46526700c1d8bda0/usr/share/rear/lib/format-workflow.sh#L32-L33 -
Workaround, if any:
Put the lineEFI=$FORMAT_EFI
right before the following line, since$EFI
is never set anywhere.
https://github.com/rear/rear/blob/7c42e2bd3e600d059f24bd0b46526700c1d8bda0/usr/share/rear/format/USB/default/300_format_usb_disk.sh#L59-L61
gozora commented at 2021-09-27 08:14:¶
Shouldn't it be usr/sbin/rear format -v -- --efi /dev/sd
(with two
dashes in front of efi
) ?
V.
bearpebble commented at 2021-09-27 08:20:¶
@gozora you are right, that was a typo in the issue. Sorry about that.
Unfortunately that is not the problem. I used the correct command and it
only worked after I applied the workaround, i.e. edited the code
jsmeix commented at 2021-09-27 08:22:¶
@bearpebble
thank you for your issue report.
It is a bug caused by me from
https://github.com/rear/rear/pull/2660
jsmeix commented at 2021-09-27 08:36:¶
Should now be fixed via
https://github.com/rear/rear/commit/d032145b15a9e9c7f8df63d4bfe1e977b41cafee
@bearpebble
please test if our latest GitHub master code that contains
that above commit works for you, cf. the section
"Testing current ReaR upstream GitHub master code" in
https://en.opensuse.org/SDB:Disaster_Recovery
bearpebble commented at 2021-09-27 08:44:¶
The usr/sbin/rear format -v -- --efi /dev/sd...
command works as
expected using d032145.
Thanks for the quick fix @jsmeix
jsmeix commented at 2021-09-27 08:47:¶
@bearpebble
thank you for your prompt test and feedback!
jsmeix commented at 2021-09-27 08:53:¶
I think less than one hour from initial user bug report
to final user confirmation that the fix actually works
is probably our fastest case that we had here.
So - now it's time for my morning coffee and breakfast...
[Export of Github issue for rear/rear.]