#2731 PR merged: Fix function modinfo_filename in 400_copy_modules.sh

Labels: bug, fixed / solved / done

jsmeix opened issue at 2021-12-20 12:28:

Fix function modinfo_filename:
Output the original module_filename also when it is a symlink
because in the code below 'cp -L' copies the symlink taget content
as a new regular file with file name as the name of the symlink
so the copied content can be still found under its original name,
cf. https://github.com/rear/rear/issues/2677#issuecomment-997859219
Additionally in case of MODULES=( 'all_modules' ) also use 'cp -L' to
copy the actual content to avoid dangling symlinks in the recovery system.

jsmeix commented at 2021-12-20 12:33:

@hpannenb
could you test it?
I would much appreciate it if you could
because I do not have your special modules as in
https://github.com/rear/rear/issues/2677
and for my simple case the code before had also "just worked"
i.e. I cannot test the special cases where it really matters.

hpannenb commented at 2021-12-20 14:52:

@hpannenb could you test it?
This PR is solving my issue #2677

jsmeix commented at 2021-12-21 09:30:

@rear/contributors
when there are no objections from you
I would like to merge it today afternoon.

jsmeix commented at 2021-12-21 14:18:

@hpannenb
thank you for your prompt testing!
It helps a lot when proposed fixes get verified by those users
on their systems where an issue had actually happened.

[Export of Github issue for rear/rear.]