#2756 PR closed: Issue #1040 shellcheck'ed version

Labels: enhancement, cleanup, won't fix / can't fix / obsolete, ReaR Project

thomasmerz opened issue at 2022-02-04 20:52:

Pull Request Details:

  • Type: Bug Fix / Enhancement (some shellcheck warnings may have led to a bug, fixing all warning might prevent future bugs which enhances this project)

  • Impact: High

  • Reference to related issue (URL):
    #1040

  • How was this pull request tested?
    First I added a GitHub Action for automatic testing in my fork, branch: https://github.com/thomasmerz/rear/tree/issue_1040_shellcheck.
    Then I made a new branch which was forked off from https://github.com/thomasmerz/rear/tree/issue_1040_shellcheck and fixed one script by another script with having the GitHub Action been checking and validating my changes.
    The final result can be seen here:

image

  • Brief description of the changes in this pull request:
    This PR has fixed all shellcheck severity levels of "error" and "warning", but not "info" and "style".

Please merge #2754 before this issue.

thomasmerz commented at 2022-02-04 20:58:

For a better user and contributors and codeowners experience you could/should add a new Branch protection rule like this:

image

jsmeix commented at 2022-02-16 09:32:

I won't find noticeable time for this pull request until ReaR 2.7 was released, cf.
https://github.com/rear/rear/issues/2751
so I set this pull request's milestone to ReaR v2.8 i.e. after ReaR 2.7 was released.

thomasmerz commented at 2022-02-18 16:49:

Output of my "local GH action" (act makes it possible):

grafik

Not completely all scripts - but this is a beginningā€¦ šŸ˜ƒ

github-actions commented at 2022-04-23 02:49:

Stale pull request message

thomasmerz commented at 2022-04-23 12:49:

Pingā€¦ just to keep this PR "active"ā€¦

github-actions commented at 2022-06-23 03:21:

Stale pull request message

thomasmerz commented at 2022-06-23 13:16:

Pingā€¦ just to keep this PR "active"ā€¦

github-actions commented at 2022-08-23 03:57:

Stale pull request message

thomasmerz commented at 2022-08-26 01:43:

Pingā€¦

github-actions commented at 2022-10-26 03:30:

Stale pull request message

thomasmerz commented at 2022-10-26 07:54:

Ping @gdha

github-actions commented at 2023-02-13 02:37:

Stale pull request message

thomasmerz commented at 2023-02-13 08:11:

What's about this PR? Should we still leave it open or are you @jsmeix @jamacku taking over this shellcheck?

jsmeix commented at 2023-02-13 12:23:

@thomasmerz
as far as I see
the current main pull request regarding ShellCheck is
https://github.com/rear/rear/pull/2847
where @jamacku explained in
https://github.com/rear/rear/pull/2847#issuecomment-1350629324
the advantages of his approach
so I think your approach in
https://github.com/rear/rear/pull/2754
became meanwhile obsolete.

In contrast this pull request here is different.
I would not merge it as is (see my comments above)
but I would like to be able to have a closer look
at each of the changes here because I assume it reveals
this or that issue in ReaR that needs to be fixed.
But I need some "spare time" to have a closer look
so I would appreciate it if this pull request here
is kept pending until I actually found time for it.

github-actions commented at 2023-04-24 02:22:

Stale pull request message

thomasmerz commented at 2023-05-12 14:03:

@jsmeix , does this PR still offer any value or should we close it due to so many conflicts and because shellcheck issues are already being fixed in other commits?

jsmeix commented at 2023-05-15 06:44:

Let's close this one because
things were implemented sufficiently well via
https://github.com/rear/rear/pull/2847 and
https://github.com/rear/rear/pull/2847
see also
https://github.com/rear/rear/issues/1040

[Export of Github issue for rear/rear.]