#2802 PR closed
: More failsafe 200_partition_layout.sh¶
Labels: enhancement
, won't fix / can't fix / obsolete
jsmeix opened issue at 2022-05-10 07:46:¶
-
Type: Enhancement
-
Impact: High
-
Reference to related issue (URL):
https://github.com/rear/rear/issues/2801#issuecomment-1122015129 -
How was this pull request tested?
Not yet tested. -
Brief description of the changes in this pull request:
In layout/save/GNU/Linux/200_partition_layout.sh
ensure the partition name/type entry in disklayout.conf
is always set (and percent encoded if needed)
at least it is set to the fallback value 'rear-noname'
regardless of the 'disk_label' value
jsmeix commented at 2022-05-10 08:36:¶
My attempt here makes things even worse!
That old code is so terribly obfuscated
that it is basically impossible to fix things
with reasonable effort.
jsmeix commented at 2022-05-10 08:52:¶
Now its sucessor
https://github.com/rear/rear/pull/2803
tries to avoid issues like
https://github.com/rear/rear/issues/2801
by ensuring a supported partition table is found
and if not it errors out.
[Export of Github issue for rear/rear.]