#2910 PR merged: Addendum for issue 2045 for Linux-ppc64le/660_install_grub2.sh

Labels: cleanup, fixed / solved / done

jsmeix opened issue at 2023-01-10 13:10:

  • Type: Cleanup

  • Impact: Low

  • Reference to related issue (URL):
    https://github.com/rear/rear/issues/2045

  • How was this pull request tested?
    I cannot test it because I don't have PPC hardware.

  • Brief description of the changes in this pull request:

In finalize/Linux-ppc64le/660_install_grub2.sh
remove the
"mount --bind <proc|sys|dev> at TARGET_FS_ROOT"
section because that is meanwhile done generically in
finalize/default/110_bind_mount_proc_sys_dev_run.sh
since https://github.com/rear/rear/issues/2045

But there the file
finalize/Linux-ppc64le/..._install_grub2.sh
was accidentally forgotten
(see its initial description).

See
https://github.com/rear/rear/pull/2047
therein see in particular
https://github.com/rear/rear/pull/2047/commits/dd9977f727b4a3a6573361cfafff833f3431f99f
and therein see the change for
finalize/Linux-i386/..._install_grub2.sh
which we supplement now also for
finalize/Linux-ppc64le/..._install_grub2.sh

pcahyna commented at 2023-01-11 13:10:

At a quick glance it looks good to me, but I have not tested it either.

jsmeix commented at 2023-01-11 14:31:

@rear/contributors
I would like to merge it tomorrow afternoon
when there are no objections until then.

[Export of Github issue for rear/rear.]