#3159 PR merged: ErrorIfDeprecated when 'gpt_sync_mbr' is used¶

Labels: cleanup, fixed / solved / done

jsmeix opened issue at 2024-02-19 14:13:¶

• Type: Cleanup

• Impact: Unknown
  It is unknown how many user will file issues
  because 'gpt_sync_mbr' is indispensable for them
  (i.e. they have no alternative to it).

• Reference to related issue (URL):
  https://github.com/rear/rear/issues/3148

• How was this pull request tested?

Works well for me.
I don't have a gpt_sync_mbr test VM so for the test I changed
in layout/save/default/950_verify_disklayout_file.sh

if test "gpt_sync_mbr" = "$parted_mklabel" ; then

to

if test "gpt" = "$parted_mklabel" ; then

to trigger it artificially with normal 'gpt'.

• Description of the changes in this pull request:

In layout/save/default/950_verify_disklayout_file.sh
ErrorIfDeprecated when 'gpt_sync_mbr' is used.

I used layout/save/default/950_verify_disklayout_file.sh
and not layout/save/GNU/Linux/200_partition_layout.sh
because in 950_verify_disklayout_file.sh
there is only one place with 'gpt_sync_mbr'
while in 200_partition_layout.sh it appears more than once
and 950_verify_disklayout_file.sh runs after disklayout.conf
was created so we check the actual final result there.

jsmeix commented at 2024-02-19 14:23:¶

My
https://github.com/rear/rear/commit/732612111ece899b354917535eb35e31cb48c4c9
is needed for my multi-line reason message here

ErrorIfDeprecated gpt_sync_mbr "The 'gpt_sync_mbr' partitioning is no longer supported by SUSE since 2016
                                see https://github.com/rear/rear/issues/3148"

that avoids a too long line for the whole reason
which could be needlessly hard to read, perhaps even with
the issue URL "out of sight" beyond the right screen border.

jsmeix commented at 2024-02-20 12:56:¶

@rear/contributors
unless there are objections I would like
to merge it tomorrow afternoon.

---

[Export of Github issue for rear/rear.]