#3192 PR merged: Set GRUB2_IMAGE_FORMAT correctly in prep/Linux-i386/330_set_efi_arch.sh

Labels: bug, fixed / solved / done

jsmeix opened issue at 2024-04-04 09:33:

In prep/Linux-i386/330_set_efi_arch.sh
set GRUB2_IMAGE_FORMAT=i386-efi
in case of i686|i586|i386
and
set GRUB2_IMAGE_FORMAT=x86_64-efi
in case of x86_64

Additionally describe current GRUB2_IMAGE_FORMAT usage
only in case of EFI so that currently it does not matter
when GRUB2_IMAGE_FORMAT is set to a value for EFI systems
also on BIOS systems, cf.
https://github.com/rear/rear/issues/3191#issuecomment-2036618057

pcahyna commented at 2024-04-04 20:11:

Add Fixes #3191 to the description and the issue will be closed automatically by GitHub after merge.

jsmeix commented at 2024-04-05 12:36:

Because of
https://github.com/rear/rear/issues/3195
I will merge this one right now
so @edmcman can test it more easily.

jsmeix commented at 2024-04-05 12:44:

I will wait for feedback, see
https://github.com/rear/rear/issues/3195#issuecomment-2039712157
until I set this one to "fixed/solved/done".

jsmeix commented at 2024-04-05 13:00:

Got positive feedback:
https://github.com/rear/rear/issues/3195#issuecomment-2039733438

jsmeix commented at 2024-04-05 13:03:

@pcahyna
my pleasure to correcting your mistake!

You corrected or avoided much more mistakes of me.

Have a nice weekend!

[Export of Github issue for rear/rear.]