#3224 PR merged: default.conf add '/var/tmp/rear.*' to BACKUP_PROG_EXCLUDE

Labels: enhancement, won't fix / can't fix / obsolete

jsmeix opened issue at 2024-05-16 10:07:

In default.conf add /var/tmp/rear.* to BACKUP_PROG_EXCLUDE
because since ReaR uses /var/tmp/rear.* as BUILD_DIR
one would get at least the whole BUILD_DIR
of the current "rear mkbackup" run
in the backup by default.

Additionally describe why ReaR's VAR_DIR/output is excluded.

Also describe why the '/directory/*' form is used, cf.
https://github.com/rear/rear/pull/3175#issuecomment-2114478980

jsmeix commented at 2024-05-16 10:53:

@schlomo
thank you for your prompt review!

pcahyna commented at 2024-05-16 18:24:

@jsmeix I don't get why you need it. You wrote:

But because of this I found out that /var/tmp/rear.*
should be added to BACKUP_PROG_EXCLUDE in default.conf
because since ReaR uses /var/tmp/rear.* as BUILD_DIR

BUT, in usr/sbin/rear there is already
https://github.com/rear/rear/blob/2e663e8705b1cd3dc8a849bae3fb02a9f4a4f017/usr/sbin/rear#L636

which should be sufficient with respect to the reasoning above (although not equivalent since there may be leftover build directories from previous ReaR runs).

jsmeix commented at 2024-05-21 11:54:

@pcahyna
what would I do without your careful review :-)

Yes, of course, you are right - and
my change was basically completely wrong :-(

I guess I had leftover build directories from
my various previous "rear -D mkbackup" runs
and didn't pay careful attention to the exact
directory names.

Yes, yes, I know, I know:
One should not do "by the way" changes
while one is actually working on something else.
One should do one thing at a time, step by step,
each one carefully and thoroughly - in theory.
In practice...

I will fix my mess with a subsequent pull request.

jsmeix commented at 2024-05-23 07:27:

This one is obsoleted by
https://github.com/rear/rear/pull/3229

[Export of Github issue for rear/rear.]