#3245 PR open: Avoid returning 1 from a script if all is OK¶

Labels: cleanup, minor bug

pcahyna opened issue at 2024-06-12 13:12:¶

Pull Request Details:¶

• Type: Cleanup

• Impact: Low

• Reference to related issue (URL):

• How was this pull request tested?
  CI has tested it - the message does not appear in the log https://artifacts.dev.testing-farm.io/54b1e241-c626-4dfb-92d4-bb369ae023db/work-backup-and-restoretjfz53h9/tests/plans/backup-and-restore/execute/data/guest/default-0/make-backup-and-restore-iso-1/data/rear-mkbackup.log anymore

• Description of the changes in this pull request:

If an error is not found in log, return 0. Not finding an error is good, so don't return 1 from the output/ISO/Linux-i386/850_check_for_errors.sh script.

Avoids the message
Source function: 'source /usr/share/rear/output/ISO/Linux-i386/850_check_for_errors.sh' returns 1
in the log.

jsmeix commented at 2024-06-14 05:13:¶

@pcahyna
feel free to disable the script for now
with an unconditioned return at its beginning
plus a comment that points to this issue here
so we could later when we actually fix it
still understand the reasoning.

gdha commented at 2024-06-20 09:49:¶

@pcahyna feel free to disable the script for now with an unconditioned return at its beginning plus a comment that points to this issue here so we could later when we actually fix it still understand the reasoning.

@jsmeix @pcahyna I would not remove the script yet as it proofs its functionality in real production environments. Some RedHat customers crawl the rear logs for this error and without a proper (replacing) check in place yet we leave them in the cold for the time being.

---

[Export of Github issue for rear/rear.]