#3261 PR `merged`: bareos: require Bareos Director >= 21¶

Labels: enhancement, external tool

joergsteffens opened issue at 2024-06-25 16:59:¶

Relax-and-Recover (ReaR) Pull Request Template¶

Please fill in the following items before submitting a new pull request:

Pull Request Details:¶

Type: Bug Fix
Impact: Normal
Reference to related issue (URL):
How was this pull request tested? manual
Description of the changes in this pull request:
The new Bareos ReaR integration introduced with #3240 uses features introduced with Bareos 20.
However, the oldest official supported version of Bareos is 21 (the current version is Bareos 23).
Therefore we add a requirement for a Bareos Director >= 21.

gdha commented at 2024-06-27 07:33:¶

@joergsteffens Please add some comment why this check is so important in script usr/share/rear/prep/BAREOS/default/450_check_bareos_config_files.sh
For the rest the code looks good to me.

joergsteffens commented at 2024-06-27 08:26:¶

@joergsteffens Please add some comment why this check is so important in script usr/share/rear/prep/BAREOS/default/450_check_bareos_config_files.sh For the rest the code looks good to me.

@gdha
Do you mean the version check in usr/share/rear/prep/BAREOS/default/460_check_bareos_director.sh? If yes, than you mean as comment in the code or as LogPrint message? As code comment I can recycle the commit comment:

The Bareos ReaR integration uses features introduced with Bareos 20.
However, the oldest official supported version of Bareos is 21 (the
current version is Bareos 23).
Therefore we add a requirement for a Bareos Director >= 21.

However, that a bit extensive as a log message. Do you have a proposal?

gdha commented at 2024-06-27 09:10:¶

@joergsteffens Please add some comment why this check is so important in script usr/share/rear/prep/BAREOS/default/450_check_bareos_config_files.sh For the rest the code looks good to me.

@gdha Do you mean the version check in usr/share/rear/prep/BAREOS/default/460_check_bareos_director.sh? If yes, than you mean as comment in the code or as LogPrint message? As code comment I can recycle the commit comment:
The Bareos ReaR integration uses features introduced with Bareos 20.
However, the oldest official supported version of Bareos is 21 (the
current version is Bareos 23).
Therefore we add a requirement for a Bareos Director >= 21.
However, that a bit extensive as a log message. Do you have a proposal?

@joergsteffens Just add the comments in the script that is sufficient - thanks. I will test the code on CentOS 8 today.
BTW - I noticed that we need jansson-2.14-1.el8.x86_64.rpm on EL8 (I had version 2.11 which resulted in bareos not being able to upgrade to the latest version).

joergsteffens commented at 2024-06-27 12:06:¶

@joergsteffens Just add the comments in the script that is sufficient - thanks. I will test the code on CentOS 8 today. BTW - I noticed that we need jansson-2.14-1.el8.x86_64.rpm on EL8 (I had version 2.11 which resulted in bareos not being able to upgrade to the latest version).

I added the comment.

But that is a problem with your installation, or?
We build the package once, but automatically test it against:
EL_8.x86_64@Alma-8-x86_64
EL_8.x86_64@Oracle-8-x86_64
EL_8.x86_64@RHEL-8-x86_64
EL_8.x86_64@Rocky-8-x86_64
EL_8.x86_64@Stream-8-x86_64

Pure CentOS 8 is dead, AFAIK.

gdha commented at 2024-06-27 15:17:¶

@joergsteffens

Pure CentOS 8 is dead, AFAIK.

Yes, that is true, therefore, I don't make a big deal of it.

gdha commented at 2024-06-28 09:51:¶

@joergsteffens PR has been merged - thank you for the quick fix.

[Export of Github issue for rear/rear.]

#3261 PR merged: bareos: require Bareos Director >= 21¶