#3331 PR merged: Use OS_MASTER_VERSION for major releases

Labels: bug, fixed / solved / done

lzaoral opened issue at 2024-10-17 07:12:

Pull Request Details:

Contrary to its name, the OS_MASTER_VERSION variable was already used for this purpose for some versions, e.g. RHEL 7. This fixes version comparison on RHEL 10 and newer.

Related: https://github.com/rear/rear/issues/3149#issuecomment-1966068640
Fixes: f4932c1cfe13d4a855bec93c1d3aa0b2b9128c6a ("Add OS version mappings for RHEL 8 and RHEL 9")

This commit has been split from #3171.

jsmeix commented at 2024-10-17 08:42:

@lzaoral
thank you for moving forward with this stuff!

jsmeix commented at 2024-10-17 13:03:

@rear/contributors
provided there are no objections
I would like to merge it tomorrow afternoon.

jsmeix commented at 2024-10-17 13:40:

A side note:

The openSUSE Tumbleweed rolling release where
OS_MASTER_VERSION = OS_VERSION = YYYYMMDD (date)
shows another reason why using version values
is almost always plain wrong, cf.
https://github.com/rear/rear/issues/3149#issuecomment-1972786350

Because for openSUSE Tumbleweed
OS_MASTER_VERSION and OS_VERSION
are continuously changing values (every few days)
correct testing for such continuously changing values
would be a laborious task with continuous maintenance
efforts to keep the tests up-to-date.

In contrast testing "the real thing"
works by design correctly.

lzaoral commented at 2024-10-18 15:02:

Thank you, @jsmeix!

[Export of Github issue for rear/rear.]