#3344 PR merged: Minor os-detection improvements

Labels: enhancement, bug, fixed / solved / done

lzaoral opened issue at 2024-11-19 11:21:

Relax-and-Recover (ReaR) Pull Request Template

Please fill in the following items before submitting a new pull request:

Pull Request Details:
  • Type: Bug Fix / Enhancement

  • Impact: Normal

  • Reference to related issue (URL): See respective commit messages.

  • Description of the changes in this pull request:

    • Set OS_VENDOR to Arch_Linux on Arch Linux
    • Remove incorrect check for SUSE_LINUX

edit: typo

jsmeix commented at 2024-11-22 08:47:

@rear/contributors
provided there are no objections
I would like to merge it on Monday afternoon.

Or is this pull request (currently for ReaR 2.8)
not really needed for the ReaR 2.8 release
so that we could postpone it to ReaR 3.0?

But it is also labeled "bug" which indicates
it is needed for the ReaR 2.8 release.

pcahyna commented at 2024-11-26 10:53:

Should we rename usr/share/rear/lib/validated/Arch? I have never used the validation stuff myself.

schlomo commented at 2024-11-26 10:56:

Yes, good catch!! Users do send new validation records (a couple per year) and I think that it is a cool feature that also gives us some personalised feedback

pcahyna commented at 2024-12-02 16:33:

@schlomo usr/share/rear/lib/validated/Arch/rolling/i386.txt contains: Validation: Arch/rolling/i386. Should we change it, or keep it how it was at the moment of the validation?

pcahyna commented at 2024-12-02 16:50:

I mean change it to Validation: Arch_Linux/rolling/i386

schlomo commented at 2024-12-02 17:14:

@pcahyna yes please, the idea is that Arch users trying rear dump will see that info, it carries a date so that they can see how old it it.

pcahyna commented at 2024-12-03 11:23:

Ok, #3353


[Export of Github issue for rear/rear.]