#3352 PR closed: cleanup: move grubby and grub2-editenv to 300_include_grub_tools.sh (#3349)

Labels: cleanup, won't fix / can't fix / obsolete

gdha opened issue at 2024-12-03 08:58:

Pull Request Details:

  • Type: Cleanup

  • Impact: Low

  • Reference to related issue (URL): #3349

  • How was this pull request tested? manually

  • Description of the changes in this pull request: grubby and grub2-editenv were added by PR #3349 into the conf/GNU/Linux.conf file in the PROGS section. However, it seems proper to move these 2 programs to the prep/GNU/Linux/300_include_grub_tools.sh script.

jsmeix commented at 2024-12-03 11:04:

According to

git log -p --follow usr/share/rear/prep/GNU/Linux/300_include_grub_tools.sh

usr/share/rear/prep/GNU/Linux/300_include_grub_tools.sh
originated in
https://github.com/rear/rear/commit/ccae513d8362078c5d4bcffe9b1167835e6449b8
but I do not understand the reason WHY it exists.

pcahyna commented at 2024-12-03 14:04:

I also don't think it should be described as feat: or Enhancement, as the change is not user-visible, isn't Cleanup more appropriate?

gdha commented at 2024-12-04 08:24:

If there are no further objections I would like to merge the PR tomorrow?

pcahyna commented at 2024-12-04 12:12:

@gdha please remove the last commit - it is totally unrelated to the PR topic.

By the way, please change the Type: in the template.

gdha commented at 2024-12-04 13:32:

https://github.com/rear/rear/pull/3354 will be used instead and we close this PR.
Noticed when we remove rear.8 from the source tree the builds will fail.

== Prepare manual ==
/usr/bin/make -C doc man
make[1]: Entering directory '/builddir/build/BUILD/rear-snapshot/doc'
asciidoc -b docbook -d manpage rear.8.adoc
/bin/bash: asciidoc: command not found
make[1]: *** [Makefile:38: rear.8.xml] Error 127
make[1]: Leaving directory '/builddir/build/BUILD/rear-snapshot/doc'
make: *** [Makefile:151: man] Error 2
error: Bad exit status from /var/tmp/rpm-tmp.Dnn2jw (%install)

[Export of Github issue for rear/rear.]