#3352 PR `open`: cleanup: move grubby and grub2-editenv to 300_include_grub_tools.sh (#3349)¶

gdha opened issue at 2024-12-03 08:58:¶

Pull Request Details:¶

Type: Enhancement
Impact: Low
Reference to related issue (URL): #3349
How was this pull request tested? manually
Description of the changes in this pull request: grubby and grub2-editenv were added by PR #3349 into the conf/GNU/Linux.conf file in the PROGS section. However, it seems proper to move these 2 programs to the prep/GNU/Linux/300_include_grub_tools.sh script.

jsmeix commented at 2024-12-03 11:04:¶

According to

git log -p --follow usr/share/rear/prep/GNU/Linux/300_include_grub_tools.sh

usr/share/rear/prep/GNU/Linux/300_include_grub_tools.sh
originated in
https://github.com/rear/rear/commit/ccae513d8362078c5d4bcffe9b1167835e6449b8
but I do not understand the reason WHY it exists.

pcahyna commented at 2024-12-03 14:04:¶

I also don't think it should be described as feat: or Enhancement, as the change is not user-visible, isn't Cleanup more appropriate?

[Export of Github issue for rear/rear.]

rear/rear-user-guide