#3364 PR merged: Fix some typos

Labels: documentation, fixed / solved / done, minor bug

castilma opened issue at 2024-12-16 14:55:

Pull Request Details:

  • Type: Documentation enhancement

  • Impact: Low

  • How was this pull request tested? Not at all.

  • Description of the changes in this pull request:
    Just fixes some text in default.conf.

jsmeix commented at 2024-12-16 15:08:

@castilma
the current actual changes in this pull request
do not fix something in usr/share/rear/conf/default.conf
but they fix correctly typos in comments in other files.

Will you add more typo fixes to this pull request
or is it finished for now so that it could be
"just merged" right now?

jsmeix commented at 2024-12-16 15:11:

No real bug (a severe typo in documentation could be a real problem)
so nothing urgent here so I set milestone to ReaR 3.0

castilma commented at 2024-12-17 10:56:

Are you referring to my issue with USB_BOOTLOADER?
Since it was mentioned that my operating system is not the target audience, I wasn't sure you were interested in something like:

--- a/usr/share/rear/conf/default.conf
+++ b/usr/share/rear/conf/default.conf
@@ -1231,6 +1231,7 @@ USB_BIOS_BOOT_DEFAULT=""
 # At the moment only empty/unset and "grub" is supported.
 # USB_BOOTLOADER="grub" uses GRUB2 as bootloader for USB with BIOS. GRUB Legacy is not supported.
 # Default is using GRUB2 for EFI other then elilo, extlinux for ext, syslinux otherwise:
+# (Whether an EFI-bootloader is installed at all is controlled by USING_UEFI_BOOTLOADER.)
 USB_BOOTLOADER=
 #
 # Resulting files that should be copied onto the USB stick:

Maybe that's not needed anymore if PR #3366 gets merged.

schlomo commented at 2024-12-18 12:58:

IMHO both this PR and your suggestion in https://github.com/rear/rear/pull/3364#issuecomment-2548143415 are good, happy to see this in 2.8 @jsmeix

jsmeix commented at 2024-12-18 13:23:

I will "just merge" it in about one hour or so
unless severe objections against "typo fixes in comments" appear ;-)

jsmeix commented at 2024-12-18 14:50:

@castilma
thank you for your contribution to ReaR!

Also small things like typo fixes matter because
correct spelling shows that we care about details.

jsmeix commented at 2024-12-18 15:11:

With
https://github.com/rear/rear/commit/d5b48f30e299049c9e6d5df1d1a19b74b3b8bdcf
I improved the USB_BOOTLOADER description in default.conf
to make it clear that for UEFI with GRUB2 also
USING_UEFI_BOOTLOADER must be set appropriately,
see https://github.com/rear/rear/issues/3362

[Export of Github issue for rear/rear.]