#392 Issue closed: Why no -t cifs?

Labels: discuss / RFC

schlomo opened issue at 2014-04-19 20:42:

https://github.com/rear/rear/blob/master/usr/share/rear/lib/global-functions.sh#L132

Why don't we specify the CIFS filesystem with a -t cifs in the CIFS mount command line? I have a user report who seems to have a problem with this.

As I don't have a test environment I don't want to change it blindly...

gdha commented at 2014-04-20 16:19:

@schlomo can you remember what the issue was with the current code?

schlomo commented at 2014-04-20 16:51:

A user contacted me privately with this issue. I will ask him to add
details here.
Am 20.04.2014 18:19 schrieb "gdha" notifications@github.com:

@schlomo https://github.com/schlomo can you remember what the issue was
with the current code?


Reply to this email directly or view it on GitHubhttps://github.com/rear/rear/issues/392#issuecomment-40898394
.

valentinnils commented at 2014-05-15 01:06:

Sorry for keeping you waiting.

Problem: Mount command for cifs not working.
We think the cifs option is not detected or passed correctly within the code.

The issue we faced was on RHEL 4 Update 6 - 32 bit.

The rear version used was the compiled rear-1.15-9.el4 from
http://relax-and-recover.org/download/ more precise
http://download.opensuse.org/repositories/Archiving:/Backup:/Rear/RedHat_RHEL-4/noarch/

The same rear version for RHEL 5 (rear-1.15-9.el5) did not have that issue.

What we tried:
First we thought its issue https://github.com/rear/rear/issues/108
But the mount command itself used manually with -t cifs option worked just fine.

Solution:
How I fixed it was in /usr/share/rear/lib/global-functions.sh in the lines 132/134 I explicitly mentioned cifs as file system (Add: -t cifs)

--- config details ---
our local.conf:

/etc/rear/local.conf
OUTPUT=ISO
BACKUP=NETFS
BACKUP_URL=cifs://xxx.xxx.xxx.xxx/Test/
BACKUP_OPTIONS=""cred=/etc/rear/.cifs""
COPY_AS_IS=( ""${COPY_AS_IS[@]}"" /etc/rear/.cifs)

PROGS=( ""${PROGS[@]}""
ifconfig
ssh-keygen
vi
vim
view
lvchange
lvconvert
lvcreate
lvdisplay
lvextend
lvm
lvmchange
lvmconf
lvmdiskscan
lvmdump
lvmsadc
lvmsar
lvreduce
lvremove
lvrename
lvresize
lvs
lvscan
lvsd
lvm.static
vgs
vgscan
vgchange
vgdisplay
lsof
rmdir
passwd )

valentinnils commented at 2014-05-16 00:47:

Let me know in case you need more details

gdha commented at 2014-05-16 12:18:

@valentinnils thank you for you feedback - need to check it and decide what to do with it

valentinnils commented at 2014-05-28 06:29:

uups I just revisited this case and saw that there are two double quotations, that must have happened when doing copy and paste, meaning first double quotation is normal ,second is escape character.

That might have led to the issue, I can't check it straight away due to server has been decomissioned.

gdha commented at 2014-08-04 12:01:

most likely no need to change the code....


[Export of Github issue for rear/rear.]